Skip to content

Variations: Add track events #8618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 13, 2023
Merged

Variations: Add track events #8618

merged 4 commits into from
Jan 13, 2023

Conversation

@Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented Jan 12, 2023 •
edited
Loading

Closes #8493

Why

This PR adds tracks for the generate all variations process. In particular, we are tracking:

Name Parameter Description
*_product_variation_generation_requested   when a user requests to generate all variations
*_product_variation_generation_limit_reached variations_count: Int when a user requested to generate more than 100 variationsThis will help us to understand the importance of supporting generating more than 100 variations, as discussed here.
*_product_variation_generation_confirmed variations_count: Int when the user confirms the generation
*_product_variation_generation_success   when generated variations are successfully created
*_product_variation_generation_failure   when generated variations are not created or existing variations are not fetched

Registration

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Ecarrion Ecarrion changed the base branch from trunk to issue/8534-generate-from-attributes January 12, 2023 15:14
@Ecarrion Ecarrion changed the title Issue/8493 tracks Variations: Add track events Jan 12, 2023
@Ecarrion Ecarrion added the feature: variation list Related to the variations list for variable products. label Jan 12, 2023
@Ecarrion Ecarrion added this to the 11.9 milestone Jan 12, 2023
@peril-woocommerce
Copy link

peril-woocommerce bot commented Jan 12, 2023 •
edited
Loading

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@Ecarrion Ecarrion marked this pull request as ready for review January 12, 2023 15:41
@Ecarrion Ecarrion linked an issue Jan 12, 2023 that may be closed by this pull request
Variations: Add tracks when generating all variations #8493
Closed
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 12, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8618-caefe40 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@rachelmcr rachelmcr self-assigned this Jan 13, 2023
rachelmcr
rachelmcr approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Base automatically changed from issue/8534-generate-from-attributes to trunk January 13, 2023 14:26
@Ecarrion Ecarrion merged commit b1e3bf3 into trunk Jan 13, 2023
@Ecarrion Ecarrion deleted the issue/8493-tracks branch January 13, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ealeksandrov ealeksandrov Awaiting requested review from ealeksandrov

1 more reviewer

@rachelmcr rachelmcr rachelmcr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rachelmcr rachelmcr

Labels

feature: variation list Related to the variations list for variable products.

Projects

None yet

Milestone

11.9

Development

Successfully merging this pull request may close these issues.

Variations: Add tracks when generating all variations

4 participants

@Ecarrion @wpmobilebot @rachelmcr